Andre Poenitz wrote:
On Thu, Mar 27, 2008 at 04:30:08AM -0400, rgheck wrote:
Attached is a more radical sort of patch, one that disentangles InsetBibtex
from the EmbeddedFiles stuff a bit, while making the logic a lot simpler, I
think. It's at least proof of concept that this kind if disentanglement can
be done. Note that it also disentangles EmbeddedFile from the
bibfilescache, etc.
Tested with various sorts of combinations of embedding, absolute and
relative paths, etc, but probably not with all. At least it makes citations
work again when you just give LyX the database name.
Comments welcome.
You added about 100 lines of code more than you removed. Is it really
simpler?
Well, yes, but I nonetheless think the overall logic is simpler. Some of
the individual methods have to be a bit more complicated, but that's
mostly a function of how parameters are represented in
InsetCommandParams. Bo had tried to sort this out, and it may be
possible to use a different representation. But I haven't looked into
that, and I'm fairly convinced that we should not be using the
EmbeddedFiles stuff to represent the parameters here. That just seems
like mixing up the wrong things.
Richard
