On Fri, Mar 21, 2008 at 05:28:48PM +0100, Jürgen Spitzmüller wrote:
> Andre Poenitz wrote:
> > > You broke the UI logic by merging the category filter into the combo.
> >
> > Well, if I am not mistaken, selecting 'all' was just another option
> > overriding everything else selected in the combobox. With 'all' selected
> > the whole dialog reacted differently.
> >
> > > My idea was that the category of a selected symbol is also indicated
> > > when all symbols are displayed.
> >
> > Ah... by switching around the selecting item in the combobox?  So if
> > 'all' is on, the combobox is 'output information', if 'all' is off, it
> > is 'primary input'?  I'd call that cruel and unusual UI...
> 
> Which is exactly what our paragraph layout combo does as well, no?
> 
> > > Furthermore, you can use the category combo for navigating
> > > (this is how such dialogs work in word processors BTW). All this is not
> > > possible anymore with your patch, AFAICS.
> >
> > Navigate where? With the patch there's an 'All Symbols' entry in the
> > combobox, seleecting it shows all symbols. Selecting e.g. 'Box Drawing'
> > selects the box symbol only etc.
> 
> If I have "all symbols" and select a category, the browser widget scrolls to 
> that category.
> 
> > Where else do we need to navigate?
> >
> > > The model/view-approach itself seems reasonable.
> >
> > So please just merge in this part. That is what solves the speed problem
> > after all.
> 
> I'll have a look.

I committed a few changes/hacks fixing part of the speed issue (for me).
Could you please have a look whether the original speed hacks can go now?
I'd polish up later...

Andre'
> 

Reply via email to