Abdelrazak Younes wrote:
Martin Vermeer wrote:
On Thu, 28 Feb 2008 16:06:39 +0100
Abdelrazak Younes <[EMAIL PROTECTED]> wrote:

rgheck wrote:
Abdelrazak Younes wrote:
The code is very weird:

if (isRequired("framed") && mustProvide("color")) {
    RGBColor c = rgbFromHexName(lcolor.getX11Name(Color_shadedbg));

This is the same problem discussed a while back concerning color handing:
   http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg135771.html
though no-one has yet done anything about it.

getX11Name() returns a named color (egg "red") and rgbFromHexName() requires an Hexadecimal color beginning with '#'. I can't believe this code is old...

[EMAIL PROTECTED] src]$ svn blame LaTeXFeatures.cpp | grep Hex
21395 poenitz RGBColor c = rgbFromHexName(lcolor.getX11Name(Color_shadedbg));
OK, this is clearly bogus. In GUI mode We could and should use Application::getRgbColor(). Problem is for non GUI mode (command-line export). I guess getRgbColor() needs to be put out of Application and become support method (using QtCore).

Abdel.


But isn't this colour only used in the GUI?

I am not sure I understand the question. getRgbColor() will just "transform" the given color into its RGB representation, this is GUI independent.
Or do you mean Color_shadedbg?

Right. This routine is converting the color names for the purposes of LaTeX output.

rh

Reply via email to