On Fri, Feb 22, 2008 at 12:35:16AM +0100, Stefan Schimanski wrote:
>
> Am 22.02.2008 um 00:33 schrieb Andre Poenitz:
>
>> On Fri, Feb 22, 2008 at 12:27:15AM +0100, Stefan Schimanski wrote:
>>> I return a const pointer now. The shared pointer is not really essential
>>> here because the ownership is clear enough.
>>
>> Better.
>>
>> The deque does not have to appear in the header either, it's private
>> static data anyway...
>>
>> And I just found in Buffer.h
>>
>>  22241        sts #include <set>
>>
>> I don't really like that either. Can't this be a vector, possibly
>> sorted?
>
> See my other mail on the list about exactly this problem. The set is not 
> the right containter, but vector isn't either... Let's wait for some 
> conclusion before optimising for the trash here.

Well, add 'no additional includes if they are not absolutely needed' to
your set of requirements then.

What's the amount of data we are talking about? Is a sorted vector
really off limits?

Andre'

Reply via email to