On Thu, 10 Aug 2000, Juergen Vigna wrote:
> > So I'm not able to test it it seems that you don't initialize variables
> > right and you don't check if they ARE initialized. I'll have a quick look
> > and see if I can solve it, if not I'll commit it AS IS and you'll be the
> > resposible if noone is trying your new code #:O)
>
> Well I had a fast look and it was cacheItem which was not initialized.
> I also removed the call of updateInset() in draw() and put there instead
> bv->text->status = LyXText::CHANGED_IN_DRAW which is the right procedure
> for insets which are changed while drawing them (you couldn't know but
> well I enlighted you ;)
Hmm, I've tested my code, but I didn't do anything extensive, just loading
a file, editing the image after it loaded, changing a parameter and then
applying, it worked for me, and I assumed it's mostly ok.
The reason I failed with this pointer stuff is that I changed the
imeplementation from being pointer to non-pointer and back to pointer, in
the changes I lost the pointer initialization and the checks.
And obivously, I had no idea whatsoever about this CHANGE_IN_DRAW trick,
that's the reason I put my comments and a warning in the code.
> I will commit now!
Thanks.
--
Baruch Even
http://techst02.technion.ac.il/~sbaruch/ (My Site)
http://rpghost.com/jindor/ (My brothers AD&D site)
" Learn to laugh ... it's the path to true love! "
- The Angel in the movie Michael
