On Thu, Feb 21, 2008 at 02:49:12PM -0500, rgheck wrote: > Abdelrazak Younes wrote: >> Richard Heck wrote: >>> Richard Heck wrote: >>>> José Matos wrote: >>>>> After Richard fix I get an assertion. >>>>> >>>>> >>>> The problem is that lcolor.getX11Name(Color_shadedbg), on LaTeXFeatures >>>> line 636, is returning "red". I'll look to see why this is, but maybe >>>> someone else knows? >>>> >>> This just looks like bad code: >>> LaTeXFeatures.cpp: 636: RGBColor c = >>> rgbFromHexName(lcolor.getX11Name(Color_shadedbg)) >>> but code that wasn't previously triggered, when it should have been. >>> getX11name() will often (even usually) return something that isn't >>> suitable input for rgbFromHexName(). In this case: >>> Color.cpp:113: { Color_shadedbg, N_("shaded box"), "shaded", "red", >>> "shaded" }, >>> so it returns "red". >>> >>> I'm guessing this code wasn't previously triggered because of something >>> to do with missing InsetLayouts. >>> >>> I don't know enough about the color stuff to fix this quickly, but >>> someone else does, I hope. Yes? >> Maybe Juergen or Uwe? > > Or JMarc or Andre? > > For what it's worth, it looks as if we need either (a) some routine that > will take these "named" colors and spit out their hex equivalents, or we > need ColorSet::ColorSet() to include the hex values directly. Or else we > need to hardcode the hex values where they're wanted.
I personally don't have a problem with hex numbers for colors. But I have no strong opinion on the whole subject. Andre'