Am 02.02.2008 um 12:57 schrieb Pavel Sanda:

Below you find the big patch pastegraphics.patch, and the smaller single
git commits which are easier to understand.

i have tested and "paste as png/jpg" basicaly works with the following oddities

- after selecting file, graphics dialog appears, but most often its not up-to-date
 with the pasted file (no filename in it eg).

No filename? Can you try to debug that? I only use the FileDialog class with some predefined filename. Maybe the dialog behaves differently on linux.

- wrong drawing of the pastedimage: only bottom part of image is displayed
 in window area and no scrollbar for scrolling upwards. when editing
its correctly repainted for the whole image, but when i delete the image then big empty space remains displayed intead of having one empty line.

Yes. That's a known problem of the scrolling code.

then two conceptual things: i would consider this feature much more useful if
it was just one click affair:

- i havent fully realized before that we need to name the file and save it. this makes the "pasting as png" not different from manual procedure i have to do with the current branch, ie not much fun. please consider to allow somehow
 to automate filenaming and saving into eg current directory (or some
 directory from preferences)

The automated filenaming should be easy. But I am note sure that this is what one wants because we still have the concept of filenames, even with the embedding feature. Of course we can put them automatically into the current directory or some picture directory. But after inserting 10 pictures you won't know anymore which picture is which.

- from similar reasons also consider whether is really needed to display the graphics dialog and let user who really want to tweak it more to click on it.

Am not sure about that. I opened the dialog nearly all the time to tweak the size of the image. So I added the line to open it.

Stefan

Reply via email to