On Sat, Jan 12, 2008 at 02:31:33AM -0000, [EMAIL PROTECTED] wrote:
> Author: rgheck
> Date: Sat Jan 12 03:31:32 2008
> New Revision: 22500
>
> URL: http://www.lyx.org/trac/changeset/22500
> Log:
> New files, anticipating a later commit.
Some non-critical hints:
> +GuiIdListModel::GuiIdListModel() :
> + QAbstractListModel()
> +{}
Unneeded as this is the same the compiler would auto-generate.
> +#ifndef GUIIDLISTMODEL_H
> +#define GUIIDLISTMODEL_H
> +
> +#include <QAbstractListModel>
> +#include <vector>
> +#include <string>
> +
> +#include "support/qstring_helpers.h"
"system" includes last please.
> + inline void setUIString(QModelIndex const & index, QString const &
> value)
> + { setData(index, value); };
'inline' is not really necessary here (but not wrong)
> + inline bool rowIsValid(int const i) const
> + {
> + return (i >= 0 && (i <= userData_.size()));
return i >= 0 && i <= userData_.size();
is less noisy.
Andre'
