Jean-Marc Lasgouttes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
I thought a bit more about that. Instead of QMenu, I'd generate a list
of Actions instead. A QMenu can be automatically constructed with
that. The idea is that this would get us closer to my idea of "Action
unification" (menu and toobar actions if you remember).
A list of actions would not be bad (provided you have an action for
Separator).
I guess 'not bad' means good here ;-) but yes, you are right, and this
'null' action would be useful for toolbar or combo separators too. This
means that one unique list of actions could be visualized in a menu, a
toolbar, a combo or a list.
The ui file parsing code can (and probably should) stay in frontends/,
for the rest each frontend (if more than one :-)) should decide what
to do with those list of actions.
Some of the algorithms (Navigation) are really painful and recreating
them every time is not funny.
Algorithms are algorithms, why do you want to recreate them? FWIW, I've
created the TocModel class for Navigation purpose and it uses
approximatively the same algorithm as in expandToc()/expandToc2(), yet
the code is smaller and more understandable IMO.
JMarc, as I said, if you're too negative about that, I won't do
anything. I understand that this is one of your first big contribution
to the code.
Abdel.
