On Sun, Dec 16, 2007 at 10:44:55PM +1800, Bo Peng wrote:
> Index: src/Buffer.h
> ===================================================================
> --- src/Buffer.h (revision 22160)
> +++ src/Buffer.h (working copy)
> @@ -202,6 +202,7 @@
> void writeLaTeXSource(odocstream & os,
> std::string const & original_path,
> OutputParams const &,
> + ErrorList &,
> bool output_preamble = true,
> bool output_body = true);
I wonder whether we should have a general 'OutputInfo' struct similar to
what we do with 'MetricsInfo'. This way additional parameters are a lot
less intrusive.
>
> Index: src/Encoding.h
> ===================================================================
> --- src/Encoding.h (revision 22160)
> +++ src/Encoding.h (working copy)
> @@ -24,7 +24,13 @@
>
> class LaTeXFeatures;
>
> +class encoding_exception : public std::exception {
> +public:
> + virtual ~encoding_exception() throw() {}
> + virtual const char * what() const throw();
> +};
>
I would not oppose the idea and do not have anything better.
Try to stick to the cosmetic conventions. Types are mostly CamelBump
nowaday e.g. And char const *.
Andre'
