On Fri, Dec 14, 2007 at 10:43:39PM -0000, [EMAIL PROTECTED] wrote:

> Author: younes
> Date: Fri Dec 14 23:43:39 2007
> New Revision: 22155
> 
> URL: http://www.lyx.org/trac/changeset/22155
> Log:
> * get rid of lyxlib.h:mkdir() and makedir()
> * Introduce FileName::createPath()
> * Fix file copying in EmbeddedFile.cpp.
...
> +     if (emb.copyTo(ext, true))
>               return true;
...
> -     if (ext.copyTo(emb))
> +             path.createPath();
> +     if (ext.copyTo(emb, true))
>               return true;
...
>       // copy file back
> -     if (!zipfile.copyTo(filename)) {
> +     if (!zipfile.copyTo(filename, true)) {

Please, simply get rid of the second parameter of copyTo() and modify
it to unconditionally overwrite the destination. Pretty please.

-- 
Enrico

Reply via email to