On Fri, Dec 14, 2007 at 07:17:59PM +0100, Abdelrazak Younes wrote: > Enrico Forestieri wrote: > > On Fri, Dec 14, 2007 at 06:49:01PM +0100, Abdelrazak Younes wrote: > > > >> Enrico Forestieri wrote: > >>> On Fri, Dec 14, 2007 at 03:32:40PM -0000, [EMAIL PROTECTED] wrote: > >>> > >>>> Author: younes > >>>> Date: Fri Dec 14 16:32:37 2007 > >>>> New Revision: 22148 > >>>> > >>>> URL: http://www.lyx.org/trac/changeset/22148 > >>>> Log: > >>>> The original support::copy() was overwriting the target file by default. > >>>> This commit put the code in line with pre-rev 22119 and 22129. > >>> I think that you should remove the second parameter in copyTo() and > >>> always overwrite the copied to file. Otherwise the changed semantic > >>> may lead to other obscure bugs. > >> Well, the copyTo() method is not used a lot ( times) and the system > >> level copy does not overwrite by default nor the Qt one; so why should > >> we? I prefer to stay with a wider spread semantics. > > > > Because we should restore the old semantics used in LyX. > > Why?
Because the rest of code expects those semantics. -- Enrico
