On Sat, Nov 24, 2007 at 08:50:29PM +0100, Andre Poenitz wrote: > On Sat, Nov 24, 2007 at 01:34:49AM -0000, [EMAIL PROTECTED] wrote: > > Author: forenr > > Date: Sat Nov 24 02:34:46 2007 > > New Revision: 21757 > > > > URL: http://www.lyx.org/trac/changeset/21757 > > Log: > > Fix some other thinkos in r21048 > > > > Modified: > > lyx-devel/trunk/src/buffer_funcs.cpp > > lyx-devel/trunk/src/support/FileName.cpp > > lyx-devel/trunk/src/support/filetools.cpp > > > > Modified: lyx-devel/trunk/src/buffer_funcs.cpp > > URL: > > http://www.lyx.org/trac/file/lyx-devel/trunk/src/buffer_funcs.cpp?rev=21757 > > ============================================================================== > > --- lyx-devel/trunk/src/buffer_funcs.cpp (original) > > +++ lyx-devel/trunk/src/buffer_funcs.cpp Sat Nov 24 02:34:46 2007 > > @@ -90,7 +90,7 @@ > > return 0; > > } > > > > - if (filename.isReadable()) { > > + if (filename.isFileReadable()) { > > I wonder whether we should have only isFileReadable() and > isDirReadable() to force 'user' code to be more explicit...
Maybe. In general, what you do with a file may not be appropriate with a directory. Those seemingly innocent changes where causing lyx to hang when opening the graphics dialog on Vista with Cygwin, because Qt was being passed a directory name instead of a file name. I really don't understand why the hang only happens on Vista and not on Win2K or WinXP, or why that doesn't happen with a native Qt even on Vista. Oh, well... -- Enrico
