>
> I'm sending here the patch that should have been in the former archive,
> this will complete the update.
>
> Sorry it was completely my mistake.
Yes this definitly was missing :)
Ok now it compiled and linked ok, I'll commit this soon!
Some more observations:
- I had to recode the patch as it was terminated with LFCR instead of only CR!
- This warnings apear you should fix them:
In file included from insetgraphics.C:157:
../../src/graphics/GraphicsCache.h:55: warning: `class GraphicsCache' only defines a
private destructor and has no friends
FormGraphics.C: In method `void FormGraphics::apply()':
FormGraphics.C:262: warning: conversion from `int' to `enum
InsetGraphicsParams::DisplayType'
FormGraphics.C:264: warning: conversion from `int' to `enum
InsetGraphicsParams::Resize'
FormGraphics.C:267: warning: conversion from `int' to `enum
InsetGraphicsParams::Resize'
- In some files you didn't respect the indentation (probably you use a tab=4
and so don't see if you indent with tab or with 4 spaces!)
- I made some small modifications look at the ChangeLog when I commit.
- Why don't you open the Dialog when creating a new inset, IMO this should
be done as you normally have to do it and this would save a mouseclick on
the inset.
- It would be really nice to have a preview button on the inset.
I didn't really have a look at the code, but this is definitively the way
to go, we now only need the inline-viewing :)
Jürgen
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen Vigna E-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel/Fax: +39-0471-450260 / +39-0471-450296
I-39100 Bozen Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Without freedom of choice there is no creativity.
-- Kirk, "The return of the Archons", stardate 3157.4
