Abdelrazak Younes wrote:
Martin Vermeer wrote:
On Mon, 05 Nov 2007 11:15:23 +0100
Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
Jürgen Spitzmüller wrote:
Abdelrazak Younes wrote:
Could you post a status update please?
Here are the bugs that must be fixed for 1.5.3, IMHO:
4301 cri crash on bookmark in ERT
This crashes only when assertion are disabled. To all package
producers, in particular for Windows (Uwe, Bo, Joost!) please, make
sure assertion are disabled in the production packages. Andre',
before you comment, I am talking about 1.5.x.
=> patch by Bernhard available.
4317 cri Cursor placement crash
Same comment!!!
There's a broken cursor apparently, should not be too hard to fix.
The attached prevents the crash. But this should be made more selective
-- e.g., force update only if the selection is multi-paragraph.
Yes. So I propose the attached patch instead.
Hum, following the wide()-removal, the situation has changed WRT bug
3992 so I committed the following to trunk instead. I guess the same fix
also applies to branch.
Abdel.
Author: younes
Date: Mon Nov 5 13:04:47 2007
New Revision: 21435
URL: http://www.lyx.org/trac/changeset/21435
Log:
Fix bug 4317 and update comment WRT current situation of trunk.
http://bugzilla.lyx.org/show_bug.cgi?id=4317
Modified:
lyx-devel/trunk/src/Text3.cpp
Modified: lyx-devel/trunk/src/Text3.cpp
URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/Text3.cpp?rev=21435
==============================================================================
--- lyx-devel/trunk/src/Text3.cpp (original)
+++ lyx-devel/trunk/src/Text3.cpp Mon Nov 5 13:04:47 2007
@@ -1083,14 +1083,14 @@
// true (on).
if (lyxrc.auto_region_delete && cur.selection()) {
+ pit_type const begpit = cur.selBegin().pit();
+ pit_type const endpit = cur.selEnd().pit();
cutSelection(cur, false, false);
- // When change tracking is set to off, the metrics
update
- // mechanism correctly detects if a full update is
needed or not.
- // This detection fails when a selection spans multiple
rows and
- // change tracking is enabled because the paragraph
metrics stays
- // the same. In this case, we force the full update:
- // (see http://bugzilla.lyx.org/show_bug.cgi?id=3992)
- if (cur.buffer().params().trackChanges)
+ // When a selection spans multiple paragraphs, the
metrics update
+ // mechanism sometimes fail to detect that a full
update is needed.
+ // In this case, we force the full update:
+ // (see http://bugzilla.lyx.org/show_bug.cgi?id=4317)
+ if (isMainText(cur.bv().buffer()) && begpit != endpit)
cur.updateFlags(Update::Force);
}
