On Sun, Nov 04, 2007 at 11:00:54PM +0200, Dov Feldstern wrote: > Dov Feldstern wrote: > >Martin Vermeer wrote: > >>On Sun, Nov 04, 2007 at 12:56:40AM +0200, Dov Feldstern wrote: > >>>Hi! > >>> > >>>Attached find the final patch (at least for now) which gets rid of > >>>LTR bias in the code. I will commit in the next few days if there are > >>>no objections. > >>> > > Attached is a newer version of this patch --- after getting feedback > from Martin and Andre' --- in two parts. p3 is basically the same as the > previous patch, sans the idxFoo stuff. p4 is a new treatment of the > idxFoo methods: I just renamed the idxLeft and idxRight to idxBackward > and idxForward, respectively. So now, there should be absolutely no > change in behavior, the entire patch consists only of renames and > comments (unless I made a mistake somewhere). > > Martin, I decided to change the idxFoo stuff even though it's only used > in math, which is entirely LTR, for the following reasons: > > *) the methods *do* appear in Inset.h, so they could potentially be used > outside of math > *) forward and backward are no less correct than left and right (even if > it is a tad less, well, visual) > *) there are places in the code which now read "posBackward && > idxBackward", which I think is slightly better than "posBackward && idxLeft" > > I hope you don't mind this too much... > > Dov
Looks OK... - Martin
