On Wed, Oct 31, 2007 at 09:30:13PM +0100, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Wed, Oct 31, 2007 at 06:24:22PM +0200, Martin Vermeer wrote: > >> // Read a font definition from given file in lyx format > >> // Used for layouts > >>-FontInfo lyxRead(Lexer & lex) > >>+FontInfo lyxRead(Lexer & lex, FontInfo f) > > > >Should be FontInfo const &. > > Or even 'void lyxRead(Lexer & lex, FontInfo & f)' if you don't need the > temporary FontInfo. But FontInfo is pretty cheap anyway. > > By the way, please use '=' instead of a copy ctor, looks cleaner: > > - FontInfo font(defaultfont()); > - FontInfo labelfont(defaultfont()); > + FontInfo font(inherit_font); > + FontInfo labelfont(inherit_font); > > + FontInfo font = inherit_font; > + FontInfo labelfont = inherit_font; > > You're doing a terrific work Martin. > > Abdel.
Thanks... I didn't bargain on doing this, but as Flex created all this low hanging fruit... - Martin
