On 10/30/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: bpeng > Date: Tue Oct 30 17:04:48 2007 > New Revision: 21291 > > URL: http://www.lyx.org/trac/changeset/21291 > Log: > Fix the shortcut input dialog bug (can not input Ctrl-blah)
Problem: setKeySymbol sets QKeyEvent::text() as KeySymbol::text_. This is wrong because C-A, C-B etc produce all sorts of strange symbols. (Run lyx -dbg key to see what I mean). When getSymbolName is called, such strange symbols are picked up because Key_A etc are not handled by qkey_to_string. Solution: Add Qt::Key_A etc to qkey_to_string so that they can be handled properly. Remaining problems of the shortcut dialog: 1. JMarc does not like the GUI but his proposal is too complicated for me to implement, and I do not see a clear advantage of his proposal. As a compromise, I have stopped displaying the confusing 'unmatched removed shortcut'. 2. Apply will actually Save the shortcuts. This is difficult to solve because there is no way to apply (keep the state), and allow later save. Because I strongly prefer the removal of the Apply button, I will NOT fix this problem. If you think this is unacceptable, you can stop applying new shortcuts and require a restart to make use of them, as 1.5.x does. Please test and report bugs. Cheers, Bo
