On Sun, Oct 28, 2007 at 12:26:46PM +0100, Abdelrazak Younes wrote: > Andre Poenitz wrote: >> On Sun, Oct 28, 2007 at 11:54:38AM +0100, Abdelrazak Younes wrote: > >>>> color_Foreground >>> This one looks weird. >>> >>>> foreground_Color >> Huh.. did I write the last two? > > Yes :-) > >> I mean color_foreground and foreground_color. > > Not good IMHO. > >>> This one looks OK as it is easily spottable. >>> >>> OK, let's make a decision and settle on one the all-caps one. >> Fine with me. What say the others? > > I have a big patch pending dealing with the Font enums. So please express > yourself quickly, otherwise I'll just commit what I have with the above > decided naming and I'll change that if there's another decision.
ALL_CAPS with enum items is ok. >>> What about constants in general? We should apply the same naming to enum >>> content IMO. >>> >>> Ex: >>> >>> Font const SANE_FONT; >>> >>> Agreed? >> Not really. That's just an instance of a class. It happens to be const >> but not enum-like. You can't use it in 'switch (...)' e.g. > > So all lower-case? OK for me too. For class instances lower case and whatever style details follow... Andre'
