Enrico Forestieri wrote:
> > If so, do you really have to enter this loop in knownLangChars in any
> > case? Can't you return earlier if a proper language is set? I guess you
> > only need to do the check for "if (prefixIs(latex1, from_ascii("\\" +
> > preamble)))" before the loop, no?
>
> Yes, but why? You would return to the loop in simpleTeXOnePar simply
> to get back here again when the next char is of the same type. This
> would be inefficient.If you say so. I didn't follow the whole chain, I'm just trying to understand your patch. > > > +Â Â Â Â Â Â Â // When the proper language is set, we are simply passed > > > a code +Â Â Â Â Â Â Â // point, so we should not try to close the > > > \textLANG command. > > > > grammar fix, please. > > What's wrong here? Do you mean replacing "so" by "so that"? No. Replace "we are simply passed a code point" by something that makes sense. > > > +bool Encodings::isKnownLangChar(char_type c, string & preamble) > > > > I think knownLangChar is not a good name. This is not about known > > languages (Greek, Russian), but about known scripts (greek alphabet, > > cyrillic alphabet). > > Probably you're right. What about knownScriptChar? That's better. Jürgen
