Hi! Thanks for the comments about the coding style. Will fix that.
@@ -248,35 +250,14 @@
return;
}
+ const_cast<MathData*>(this)->updateMacros(mi);
+
Couldn't you declare some member variable _mutable_ instead of
using const_cast?
Well, I reorganize the insets in the MathData. Not sure if it makes sense to use mutable here. In fact this question suggests that updateMacros should be called from somewhere else, not the metrics method. But of course I don't want to integrate a third non-const pass to the rendering for this stuff. Does anybody have a good idea how to do integrate this in a cleaner way?
Please, rework the code if there's more than three levels of
indentation, ex, use:
if (!macroInset)
continue;
and de-indent the rest.
Good point.The method is far too long and I would like to split it. But there is quite some logic involved which makes this hard. Will take another look though.
I don't have the courage nor the time to go further.
Thank you anyway. Fixing the indenting now. Stefan
PGP.sig
Description: Signierter Teil der Nachricht
