Enrico Forestieri wrote:
On Sun, Oct 21, 2007 at 11:46:11AM +0200, Andre Poenitz wrote:
On Sun, Oct 21, 2007 at 12:33:27PM +0300, Martin Vermeer wrote:
On Sun, Oct 21, 2007 at 06:22:09AM +0200, Enrico Forestieri wrote:
On Sat, Oct 20, 2007 at 11:08:09PM -0000, [EMAIL PROTECTED] wrote:
Author: broider
Date: Sun Oct 21 01:08:02 2007
New Revision: 21092
URL: http://www.lyx.org/trac/changeset/21092
Log:
Search for toolbar images in the filesystem and afterwards in the resource.
Now I really wonder what is the benefit of having resources compiled
in, given that the images are still searched on disk. Someone could
explain that? My impression is that now we have a 1Mb fatter executable
and no real benefit...
My impression is that the images are searched for, but only
those are loaded from the disk that are found there. I suppose
the latter is more work than a directory scan.
My impression is that people should check _their_ numbers first and
complain then. Preferably with a description that's suitable to
reproduce those numbers.
$ ls -l src/lyx*.exe
-rwxr-xr-x 1 root 21148998 Oct 21 01:22 src/lyx.exe*
-rwxr-xr-x 1 root 19975298 Sep 12 00:32 src/lyx-old.exe*
Isn't the only relevant number the startup time?
Somewhere the pngs must come from.
So, today the executable size is 1Mb bigger than the size on
September 12. To reproduce, follow the steps outlined at
http://wiki.lyx.org/LyX/LyXOnCygwin
My other impression is that people should _think_ more about the
consequences of implementing their "cool" feature and check whether
the advantages they claim are really advantages on systems different
than theirs.
IMO, after this patch the resources thing is useless if not detrimental.
--
Peter Kümmel
