Andre Poenitz wrote:
On Sat, Oct 20, 2007 at 06:55:18PM +0200, Peter Kümmel wrote:
As far as I can tell using QtCore in support/*.cpp is acceptable
nowadays, so just use QProcess and be done.
also mocing?
Ask the others. I don't have a problem with it.
I will wait for some reactions...
I mean
QTextEdit* GuiViewBase::progressWidget() const
static QTextEdit* progressWidget();
Maybe this will change.
#include "..."
What's wrong with <...>?
It's conceptionally for system libraries. Also, we use "..." for our
stuff consistently and I see no reason to deviate from that practice.
ah, ok.
Isn't the code more readable with the else?
Not in my opinion. Less line noise, a level less of indentation.
I change it.
[Why not create new code with tabs from the beginning?]
In a other project I have to use spaces.
So just do that (unless some of the others shout louader than I).
Before the patch is ready for checkin the DockWidget should
also be present in the menu, but I don't know how to add it, it's
really not the Qt way.
I also plan to add some "processed page" info, by parsing the output
for [x]. Does anybody know the correct regex, something like [\d].
Peter
