On Mon, Oct 15, 2007 at 10:04:45PM +0200, Jean-Marc Lasgouttes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
> 
> > What's the official policy wrt dynamic_cast<>?
> >
> >
> > We currently have
> >
> > frontends/qt4/GuiView.cpp:              GuiWorkArea * wa = 
> > dynamic_cast<GuiWorkArea *>(d.tab_widget_->currentWidget());
> 
> > So it looks like we already use it.
> 
> For somebody who thinks that camelBump with underscore is an
> abomination, you seem very lenient with
> under_score<CamlBump>(camelBump), which at least as ugly.

I did not propose to use dynamic_cast<>().

It was a question.

> What about giving a reasonable API to TabWorkArea instead?
> 
> I can understand dynamic_cast in places where virtual inheritance is
> heavily used, but the case above does not seem to be in this setting.
> 
> > If so, all the asFooInset() methods could go, right?
> 
> At least these are readable.

I guess I introduced about 80 or 90% of them...

Andre'

Reply via email to