Bernhard Roider wrote:
Abdelrazak Younes schrieb:

+/// information for a macro
+struct LyXAction::macro_info {

macroInfo please.

this one is similar to func_info in the same class

I know and this is bad too. Feel free to correct that too ;-)

+    case LFUN_CALL: {
+        FuncRequest func;
+        std::string name(to_utf8(cmd.argument()));
+        if (lyxaction.lockMacro(name, func)) {
+            func.origin = cmd.origin;
+            flag = getStatus(func);
+            lyxaction.releaseMacro(name);
+        } else {
+            // catch recursion
+ // all operations until the recursion occures are performed, so
+            // set the state to enabled

Hum, if the recursion problem is frequent, this deserve an alert dialog to the user. You can use ExceptionMessage if you prefer.

i think a dialog in the getStatus method is no good idea - it would come up really frequently. but maybe in the dispatch method?

OK.

the reason for the recursion detection is mainly because lyx would otherwise crash with a stack overflow.

I trust you :-)

Abdel.

Reply via email to