I've finished the InsetGraphics portion, it currently does everything
InsetFig does besides the inline viewing, it does everything with the
graphicx package instead of graphics.

I'll upload it shortly to my website, it will be found in:
http://techst02.technion.ac.il/~sbaruch/InsetGraphicsUpdate.tar.gz

This includes all added source files and a patch against the latest CVS
tree. This is mostly usefull if you want to see what I've done and try it.
I still need to clean up the way it replaces the InsetFig (a
NEW_INSETGRAPHICS define?), so unless you want to do this cleaning
yourself and commit it into the cvs you should try this on a backup
checkout.

Effectively I have added nearly no functionality, I did change the way
things work in the dialog though to make it simpler for the user.
Specifically if you want to change to inline the image you need not
recreate the inset as before, it now checks for (mostly) valid input and
will not allow you to press apply/ok if the dialog is not in a valid
state. (width == 0 and you want to size by cm for example).

Another neat (IMNSHO) feature is the fact that if you changed nothing in
the dialog and pressed ok or apply the dialog will not be flagged as
changed. however it still does not handle the case that you actually
changed something, applied it and changed to the former state and applied
again the document will stay marked as changed.

I'll now dig into the GraphicsCache and FormatTranslator, this will take a
while longer, it requires some deep thinking (and understanding the way
ExternalInset currently works).

Comments on coding style and everything else you have a comment about are
welcome.

-- 
  Baruch Even

http://techst02.technion.ac.il/~sbaruch/   (My Site)
http://rpghost.com/jindor/                 (My brothers AD&D site)

" Learn to laugh ... it's the path to true love! " 
   - The Angel in the movie Michael


Reply via email to