On Tue, Oct 02, 2007 at 09:09:33AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Tue, Oct 02, 2007 at 08:11:47AM +0200, Abdelrazak Younes wrote: > >>Andre Poenitz wrote: > >>>The attached patch replaces the signal/slot connections between Buffer > >>>and BufferView to LyXView by ordinary delegates. > >>> > >>>There has always been only (at most) a single connection of each type > >>>with known endpoints, so full-blown signal/slot was overkill anyway - > >>I am sorry but that's not true for Buffer. With multi-workarea and > >>multi-view there can be more than one connection to the > >>Buffer::changed() signal. > > > >The signal was only attached to the LyXView, not to the workarea. > > Wrong, in WorkArea.h: > > /// buffer changed signal connection > boost::signals::connection bufferChangedConnection_; > /// buffer closing signal connection > boost::signals::connection bufferClosingConnection_;
Urm ... right. That was not too conciously, though. I tought I had taken an approach of "'no compiler error' means 'works as before'". I missed that bit. > Wrong, see above. You can have two WorkAreas sharing the same Buffer in > the same LyXView. I'd really like this to stay. I'll come up with a solution for that. Andre'
