JMarc> Angus> Attached is a small patch to FormPreferences and FormPrint,
JMarc> Angus> moving #include "form_xxx.h" out of the .h files and into the
JMarc> Angus> .C files, replacing them with forward declarations of the
JMarc> Angus> relevant structs.

JMarc> Angus> All files in the src/frontends/xforms/ directory are now self
JMarc> Angus> consistent in this regard.

JMarc> Hmm, why is this situation better? Not that I am against the patch, I
JMarc> just want to know.

Because unnecessary inclusion of header files in header files is evil? 
Actually, it means that Dialogs.C no longer depends on form_xxx.h, so you
can play with the forms and not have to recompile as much code. Let's just call
it "more elegant"!

JMarc> Anyway, I won't commit it until you send a ChangeLog :)

2000-07-19  Angus Leeming  <[EMAIL PROTECTED]>
        * src/frontends/xforms/FormPrint.[Ch] : moved #include form_print.h out
        of the header file. Replaced with forward decarations of the relevant struct.

        * src/frontends/xforms/FormPreferences.[Ch] : ditto for form_preferences.h.

Angus

Reply via email to