On Tue, Sep 25, 2007 at 12:52:36PM -0400, Richard Heck wrote:
> In working on the InsetCommand stuff, I ran across this. Somethind 
> should be done here, but I'm not sure what and will make a proposal.
> 
> The patch is attached. The issue is with the test
>    if (!p.getCmdName().empty()) {
> The problem is that, so far as I can see, there is absolutely no way 
> this can trigger. So I'm proposing to replace it with a try-catch block: 
> string2params throws an exception when it encounters an error, so we can 
> catch it and act appropriately. Does this seem reasonable?

If it can't happen, an assert sound reasonable.

Andre'

Reply via email to