On Sun, Sep 16, 2007 at 08:57:32PM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Sun, Sep 16, 2007 at 12:18:56PM +0200, Lars Gullik Bjønnes wrote: > >>I just did a some test compilations with gcc 4.2 and gcc 4.3 (from gcc > >>trunk), and got both some new warnings and a few errors. This patch > >>fixes those. > >> > >>The main variants of warnings/errors: > >> * Ambigous else > >> * Ambigous logical operators > >> * Headers in libstdc++ cleanup, requireing more includes > >> * Lookup changes, resulting in the need of more "using std::XX" > >> * Initialization out of order > >> > >>I also couldn't help myself on moving a static func into anon > >>namespace, changing some params to be const ref, a very few ws > >>changes. Where easy I will commit thos unrelated changes as separate > >>commits. > > > >I think there's no problem with commiting those oin one go. > > ?? So you're fine with Lars undoing your "anon namespace -> static" change? > > Just trying to be polemic ;-)
Go ahead. You certainly need more practice there. There are situations where that is formally necessary, for instance when the function is used in a template instantiation. Traditionally, this has not been a technical problem, but as the Standard requires sometimes strange things, a conforming compiler is forced to require strange things as well. Andre'
