Jean-Marc Lasgouttes wrote:
"Bo Peng" <[EMAIL PROTECTED]> writes:

I find it useful. Maybe others too.
It is useful, but it is not so difficult to switch to the master
buffer and generate preview from there. We already have many items
under the View menu, and a shortcut-only hidden feature is not that
appealing.
I think this is typically the feature that is useful for power users
and therefore can be bound to something without being in the menus.
Agreed.
All the range of export types should be supported, though.
And it is, as Tommaso has it.
Tommaso, I do not think it is necessary to check whether
getMasterBuffer returns null. AFAIK, this cannot happen.
Right. getMasterBuffer() will return the current buffer if it's not a child, so this should work:

+               case LFUN_MASTER_VIEW:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
+                       
Exporter::preview(lyx_view_->buffer()->getMasterBuffer(), argument);
+                       break;
+

Nice and clean.

Richard

--
==================================================================
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==================================================================
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto

Reply via email to