> > Looking at the code in Buffer.cpp, I do not think this is a good idea:
> >
> > Write:
> > // now write out the buffer parameters.
> > ofs << "\\begin_header\n";
> > params().writeFile(ofs);
> > ofs << "\\end_header\n";
> >
> > Read:
> > while (lex.isOK()) {
> > string unknown = params().readToken(lex, token);
> > if (!unknown.empty()) {
> >
> > You can see that header <==> params() so unless I move embedded_files_
> > to params(), this does not look right.
>
> I know and that is my point. :-)
> Do you disagree?
Moving Buffer::pimpl_::embedded_files_ to BufferParams is not
particularly difficult, but I do not see any benefit either.
> > + # LyX file format <= 284 does not have a manifest section
> > + # so this section is set to None
> > + if self.manifest is None:
> > + manifest = []
> > + else:
> > + manifest = ['\\begin_manifest'] + self.manifest +
> > ['\\end_manifest']
> > +
> > + for line in header + [''] + manifest + [''] + self.body:
>
> I would suggest to include one of the empty lines above in manifest so that
> if we don't have a manifest we don't get two consecutive empty lines (this is
> cosmetics).
OK.
> I like this. That was what I was thinking. :-)
Then what remains is whether or not you want to move embedded_files_
to BufferParams. I am neutral about this.
Bo
