Jürgen Spitzmüller wrote: > Alfredo Braunstein wrote: >> Have commited a couple of optimization patches that are worth considering >> for branch IMO and that I don't see on the list for some reason: >> >> r20016: optimization: avoid some font copying >> >> r20021: enable some non-rtl optimization > > probably because they do not appear on lyx-cvs (at least I don't have > them). > > Are you sure these are safe? Optimization is certainly welcome (I just had > to downgrade to 1.4.5 on my Laptop because 1.5svn is unbearably slow :-().
r20016 IMHO yes (is just Font -> Font const &). I think it may be important because it is in get[Display]Font, which is sort of in the inner loop of the metrics/draw call r20021 makes an isRTL test to avoid doing font checking to determine if there is RTL text at a certain position if rtl is not active. The check was there, but non-operative due to a small bug. So *should* be safe. Dunno about the real performance impact. It would be nice if someone else had a look at them though, just to be safer. A/
