On Sun, Sep 02, 2007 at 10:53:30PM +0200, Alfredo Braunstein wrote:
> Abdelrazak Younes wrote:
>
> >> --- lyx-devel/trunk/src/TextMetrics.cpp (original)
> >> +++ lyx-devel/trunk/src/TextMetrics.cpp Sun Sep 2 20:05:37 2007
> >> @@ -155,7 +155,7 @@
> >> Dimension const old_dim = dim_;
> >> // reset dimension.
> >> dim_ = Dimension();
> >> - size_t npar = text_->paragraphs().size();
> >> + pit_type const npar = text_->paragraphs().size();
> >
> > It's probably time to make pit_type unsigned...
>
> I don't know if I'd like that. The fact is that even if one want to store
> non-negative values, one normally wants to have integer operations, not
> operations in Z mod 2^{32}. Where you may get unexpected results like pit -
> 1 > pit, for no real apparent gain.
That's why I think that using unsigned types for size_t is ... "unlucky"
to say the least.
Andre'
