Andre Poenitz wrote:
On Wed, Aug 29, 2007 at 06:57:47PM -0400, Richard Heck wrote:
Andre Poenitz wrote:
I am tempted to commit the attached patch. Shaves ~22s off a release
build, i.e. roughly 1.2% of total time. Not exactly much, but a dozen of
such trivial changes will show...
Do we know why auto_ptr was used for all of this?
Sure. Lars wanted to have the non-virtual interface idiom somewhere in
LyX, yet decided not to convert the remaining 84 virtual functions in
class Inset. Not that I am too unhappy about giving up this particular
idea after 1/85...
OK, so I went and googled "non-virtual interface idiom". Can explain to
me why auto_ptr needs to be used to do that here? I'm still learning C++....
Richard
--
==================================================================
Richard G Heck, Jr
Professor of Philosophy
Brown University
http://frege.brown.edu/heck/
==================================================================
Get my public key from http://sks.keyserver.penguin.de
Hash: 0x1DE91F1E66FFBDEC
Learn how to sign your email using Thunderbird and GnuPG at:
http://dudu.dyn.2-h.org/nist/gpg-enigmail-howto
