Abdelrazak Younes wrote:
Abdelrazak Younes wrote:
Alfredo Braunstein wrote:
Text::dispatch(LFUN_FLOAT_INSERT) calls dispatches
Cursor::dispatch(LFUN_CAPTION_INSERT) to insert the CAPTION. One
possible general problem with this may be that Cursor::dispatch is not
reentrant-safe (see beforeDispatch members).
I've looked at it more closely and you're right. We should either use
the local Text::dispatch() method or make sure the savings of
beforeDispX and beforeDispY happen before Cursor::dispatch():
// store some values to be used inside of the handlers
getPos(beforeDispX_, beforeDispY_);
For trunk, I think we should replace all occurence of
cur.dispatch() with this->dispatch() in Text3::dispatch().
Actually there are not a lot:
- one in Text::cursorPrevious()
- one in Text::cursorNext()
- one in LFUN_MATH_*
- one in mathDispatch().
Abdel.
