Bo Peng wrote:

> Thank you for reviewing the patch.
> 
>> > +     for (FileList::iterator it = file_list_.begin(); it !=
>> > file_list_.end(); ++it)
>> > +             it->invalidate();
>> >
>> Same for-style here...
> 
> I am not quite sure about this style issue. Is
> 
> FileList::iterator it = file_list_.begin();
> for (; it != file_list_.end(); ++it)
>     it->invalid();
> 
> recommended over the one I used? Jose?

I personally like much better yours ("it" scope is local).
In any case I think (may be wrong) LyX style is something like

FileList::iterator it = file_list_.begin();
FileList::iterator const end = file_list_.end();
for (; it != end; ++it)
        it->invalid();

A/


Reply via email to