On Thu, Jul 06, 2000 at 01:01:19PM +0200, Lars Gullik Bjønnes wrote:
 
> 
> I can only say that LaTex was never intended to be subclasses
> from...so I really don't like that part of the patch...

In this case, why is scanLogFile declared "protected"?

> 
> The whole LaTeX class is specially tuned for LaTeX running and log
> parsing, I'd rather see the classes that subclass it rewritten.
> 

Yes but the noweb file can be considered to be _both_ a LaTeX file _and_ a program 
source file.  This seems a classic case of that would justify subclassing. It would 
seem reasonable to use the LaTeX class's scan function to scan logs.  This does not 
mean that the patch does things the best way though.  It might be better to have two 
virtual functions "userError" and "userWarning", say, that are called insid 
"scanLogFile" and that can be re-defined in the subclass.  However the present patch 
should not break anything and I could put the re-implementation on my "todo" list.

Bernard

Reply via email to