Abdelrazak Younes wrote: > Alfredo Braunstein wrote: >> Abdelrazak Younes wrote: >> >>> Here is a patch with this fix against latest trunk. >>> >>> Abdel. >> >> + void LyXView::setBuffer(Buffer * newBuffer) >> >> shouldn't this be called something like addBuffer ? > > It's between the two notions. It will indeed add a WorkArea if it does > not current exist and switch to it otherwise. Should probably be > setWorkArea() instead. I'll change that afterwards, I don't want to be > accused to augment the patch even more.
Ah, right. Yes, setWorkArea seems better indeed. I just read the patch. What can I say, it is a very long patch and I couldn't follow many things, but it definitely feels like a step in the right direction. And it does seem very difficult to break it up further. Summary: I personally don't have objections. I think we can figure out missing details later. However, given the firework that the thing has started, I think it wouldn't hurt to wait until Monday evening (many here work on lyx only on weekdays and you posted the last patch on friday). On a very fast testing, I noticed two small problems (I don't think this should stop the patch though): - menu shortcuts (M-f, M-h etc) are disabled on the splash screen (menus can still be opened with the mouse) - in some cases the cursor is almost offscreen on opening (in some cases the scroll bar is missing when opening short document, but pops up when clicking.). I'm not even sure that this problem is not already on trunk. A/
