On Fri, Aug 17, 2007 at 11:53:02AM +0200, Jean-Marc Lasgouttes wrote:
> Richard Heck <[EMAIL PROTECTED]> writes:
> 
> > With those suggestions, here is the putatively final patch. I intend
> > to commit as soon as the trunk will build again and I can verify that
> > everything works there. I've done that at 19520, but current svn won't
> > build completely. I'm also attaching the log.
> 
> I know I am late in the game, but I just noticed that the file
> Biblio.cpp uses the uppercase convention for files implementing a
> class. Shouldn't is be biblio.*, or even biblio_funcs.* instead?

One of the reasons I'd go for AllCamelBump in file names, no matter
whether it's a class or a namespace. Next time I don't remember that
the biblio stuff is not a class and try to edit the 'wrong' file.
Pretty useless complication...

Andre'

Reply via email to