On Fri, Aug 17, 2007 at 02:25:14PM +0200, Abdelrazak Younes wrote: > Enrico Forestieri wrote: > > On Fri, Aug 17, 2007 at 02:08:17PM +0200, Abdelrazak Younes wrote: > >> Martin Vermeer wrote: > >>> On Fri, Aug 17, 2007 at 11:00:07AM +0200, Abdelrazak Younes wrote: > >>>> Martin Vermeer wrote: > >>>>> On Fri, Aug 17, 2007 at 09:22:16AM +0200, Abdelrazak Younes wrote: > >>>>>> Martin, > >>>>>> > >>>>>> This is for you I guess: > >>>>>> > >>>>>> src\insets\insetcollapsable.cpp(71) : warning C4715: > >>>>>> 'lyx::InsetCollapsable::geometry' : not all control paths return a > >>>>>> value > >>>>>> > >>>>>> Abdel. > >>>>> Yes, I am getting that too: control reaches end of non-void > >>>>> function. But if you manually trace the function, you see that it > >>>>> cannot really happen ;-) Is the compiler being over-careful? I suppose > >>>>> we could > >>>>> shut up this warning. But should we? > >>>> No, just put a dummy warning at the end: > >>> That's what I meant by shutting up. > >> Ah... I thought you meant disabling it at compiler level. > >> > >>> > >>>>> Actually the breaks are unnecessary too. > >>>> Indeed. See patch. > >>> I would comment this (the break thing) a bit. > >> What do you want comment? > >> > >>> Otherwise > >>> I am OK with the patch. > >> OK, I'll commit and I'll let you put the relevant comment then. > > What about the attached? > > That's fine too, only a bit more verbose. But I already committed my patch. > > Abdel.
Also slightly less efficient -- unless the optimizer takes the extra detour out again. Which I don't really expect a compiler to do that doesn't recognise a complete set of exits ;-/ - Martin
