Alfredo Braunstein wrote:
Abdelrazak Younes wrote:

Either Alfredo or JMarc I guess...

Pretty sure it's not mine... :-)

It's JMArc then :-)

Here is a fix. What is the purpose of this DocIterator::forwardIdx()?
If we are within a cell, pit_ and pos_ are not important. I think we should get rid of it, ++it.idx() is meaningful enough.

Abdel.

Index: InsetTabular.cpp
===================================================================
--- InsetTabular.cpp    (revision 19553)
+++ InsetTabular.cpp    (working copy)
@@ -3194,7 +3194,8 @@
 
        ParIterator it2 = it;
        it2.forwardPos();
-       for ( ; it2.idx() <= it2.lastidx() ; it2.forwardIdx())
+       size_t const end = it2.nargs();
+       for ( ; it2.idx() < end; ++it2.idx())
                lyx::updateLabels(buf, it2);
 
        //reset afterwards

Reply via email to