Alfredo Braunstein <[EMAIL PROTECTED]> writes: > This patch removes some code duplication in DocIterator (in particular > removes forwardPosNoDescend that if nothing else, has an ugly name), by > moving the part of forwardPos that acts on flat cursorslices to > CursorSlice::operator++. Comments?
Well, Andre's first comment was "it's from Alfredo, it is correct". However, after we forced ourselves to actually read the code, we are unsure that the patch is a good thing. forwardPosNoDescend may be ugly, but it is quite explicit. ++cur.pit() requires much more thinking to be sure of what it means. The original version in particular can go outside of insets and continue from there, which is not the case of the CursorSlice one. Also concerning setFont, I am not sure we want to use CursorSlice as parameter, although it makes sense technically. Things will get soon annoying if for each function one has to wonder whether to use a full cursor or a slice... All in all this looks like purely cosmetic, but I am do not really like the end result than the starting point. JMarc
