> > as in the attached patch. (The logic is a bit complicated, and I hope > > I got it right. :-) > > It is right, but less easy to understand IMHO. If I read > > if (buffer->isProbablyNotExternallyModified()) > do something > > I know that the test is not 100% safe. If I read > > if (buffer->isExternallyModified(false)) > do something >
I know, but isProbablyNotExternallyModified() can be confusing as well. It is unfortunate that C++ does not yet accept keyword argument, and it does not look pretty to use isExternallyModified(/* fast= */ false) as some C++ guru suggested. Bo
