Hi,

On 05.07.2007, at 10:28, Jürgen Spitzmüller wrote:

Abdelrazak Younes wrote:
some testing would surely be good (that would speak for
putting it in soon after a minor 1.5.x release).

Please test it then. Dov already tested it with RTL language and didn't
see any problem at all. I repeat myself but the only side effect that
could happen is that some characters are cropped to the left or to the
right. But I am pretty sure now that I took all possible cases into
account.

I don't have much time for testing, but the more important is if it improves the Mac situation. So let's wait what the testing there results in, and then José will have to decide on this anyway (if it is scheduled for 1.5.0).

I have sent the results directly to Abdel, I had a closer look at them now:

The function QFontEngineMac::draw uses 8.4% (of overall runtime) in the unpatched version and almost nothing in the patched version. This seems to provide more runtime for QCoreGraphicsPaintEngine::drawPixmap(unpatched: 7.9%, patched: 18.4%).
(This is confirmend by two individual measurements.)

Andi

Reply via email to