Richard Heck wrote:
Helge Hafting wrote:
Richard Heck wrote:
This fixes a bug reported by Helge: changing the paragraph style
needlessly resets all the paragraph parameters. This is important to
fix in the context of the recently committed fixes to paragraph
settings.
I'd appreciate it if someone could commit this for me, once we get
the OK. I'll be on vacation starting tomorrow. Here's a log message:
Fix bug 3939. Don't reset all the parameters when the layout is
changed,
but instead: Check if the alignment is permitted; if not, issue a
warning,
and reset to LYX_ALIGN_LAYOUT.
I tested the patch and it works. The alignment setting is now
preserved over layout changes, as long as the alignment set is
valid in the new layout. Very good!
A couple of small issues:
* Changing the layout to something that doesn't support the
current alignment bothers me with a message box.
(For example, when turning a right-aligned paragraph into "title".)
The message box hampers workflow as one have to click on "ok",
and the message isn't important enough to justify that.
A message printed on the status bar would be much better,
that is what the status bar is there for. The status bar is nice
in that you don't have to _do_ anything after reading the message,
the status line don't demand useless action.
I'm leaving for vacation in a few minutes. Someone else, hopefully,
can fix this. Or I can do it when I get back.
Great! I hope this small issue won't hold the patch back.
* The paragraph settings dialog is now modal - I _have_ to close
it before continuing work in LyX. Non-modal is nicer as one
don't have to close it.
Yes, it has been for a while. The reason is that there is no way to be
sure it gets updated if the cursor gets moved. We're working on this,
too.
Nice to hear. Have a nice vacation!
Helge Hafting
