Jean-Marc Lasgouttes wrote:
"Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes:

Dov> Attached is the patch using current_font. Is this Okay?

The patch is definitely correct. Please apply.

Thanks, committed.

Dov> Could the versions of insertInset which do not take a font be
Dov> made private, so that one would always have to provide a font
Dov> explicitly?
Yes, I think we should do this (or even check whether these versions
are useful at all).

JMarc


In that case, it looks like there's only one other place where the form without a font is still used:

Paragraph::checkBiblio(bool track_changes)

I'm not familiar with this function at all. However, it is only used in one place, so I think that it should also get a font, and then call insertInset with a font. I don't know which font should be used here, though. Also note that this function (checkBiblio) has a big FIXME at the top anyhow...

I'll try to send a patch which does all this...




Reply via email to