Andre Poenitz wrote:

In the 1.6 cycle I'd like to get rid of the 'Dimension' data member in
Inset. As a lot of insets need that member and derivation from a
'common' 'DimInset' base was impractical I am thinking about using the
old ATL trick:

I think this is too complicated. A better solution IMHO is to remove the data member altogether and put that in the BufferView (either in the CoordCache or in in a new DimensionCache):

class BufferView {
        Dimension const & dimension(Inset const &);
}

Maybe we also need a simple flag in Inset would then tell if the Inset Dimension needs to be cached or not:

class Inset {
        virtual bool cacheDimension() { return false; }
};

Abdel.

Reply via email to