On Wed, Jun 13, 2007 at 08:59:56AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Wed, Jun 13, 2007 at 07:22:47AM +0200, Stefan Schimanski wrote: > >>>can end up in MathData.cpp? > >>This question I have asked myself so many times, but not only about > >>this piece of code. > >>Btw, two lines of the block above are by you ;-) > > > >That was the global MathArray -> MathData renaming, no 'active' change. > > There is a very good chance that the code between the '#if 0' is yours. > At least it predates my venue in this code.
Sure enough. That's why svn log shows 'younes' as author of 17840 and 'svn diff -r 17839:17840' shows that all the lines within the #if 0 are added and not moved around (in this case they would have been removed somewhere else). Pretty much looks like my doing as far as I can tell... > >I don't like big chunks of '#if 0''d code go in without good reason. > > That surely is the reason why mathed is full of '#if 0'... That's usually code that was active once and is on the way out. I do that if I am not sure whether the approach is sound or if it is code I do not understand. In any case this is a bit different from inserting 'new code in #if 0'. Andre'
