- In the Listings dialog, the "Bypass validation" checkbox should go to
the "Avanced" tab. Furthermore, it lacks an accelerator and a tooltip (in all
three dialogs).

Sorry, I know they are supposed to be easy, but I do not know qt well
enough to add accelerator and tooltips. I guess you can add them once
the patch is committed. :-)

- toggling this checkbox doesn't have an immediate effect (in alle three
dialogs). You have to type something first. You'll need to add a slot
on_bypassCB_stateChanged(int state) that does the necessary things.

I will have a look.

> +if (msg.empty())
> +return msg;
> +else
> +return bformat(_("Parameter %1$s: "),
> from_utf8(name)) + msg;

return bformat(_("Parameter %1$s: %2$s"), from_utf8(name), msg);

OK.


> +qt_("Input listings parameters on the right. Enter
> ? for a list of parameters."));

I think we can ditch this message completely. The same message is given as
tooltip, where it makes more sense IMHO.

The box is empty so why not put the hint there?


> revert = [
> + [271, [revert_preamble_listings_params, revert_listings_inset,
> revert_include_listings]], [270, [revert_ext_font_sizes]],
> [269, [revert_beamer_alert, revert_beamer_structure]],
> [268, [revert_preamble_listings_params, revert_listings_inset,

Hm, that's not exactly what I had in mind. But if you're too lazy and José is
fine with it, I can live with that.

If you want to support RC1, this is the only method. Because there is
no easy way (in lyx2lyx) to tell if a parameter string is valid, we
have to assume that they are invalid and use ERT in 1.5.rc1.

Cheers,
Bo

Reply via email to